CI: one integration-test binary per crate, ci-test profile, mold #18

Manually merged

krisbuild merged 3 commits from faster-tests into main 2026-09-27 19:50:30 +02:00

Conversation 5 Commits 3 Files changed 37 +96 -33

kris commented 2026-09-27 19:33:37 +02:00

Owner

Copy link

The Nix test check spent 30+ min compiling before any test ran (e.g. graph 582). Measured on ares (16 cores):

• cargo test --release --no-run for the workspace crates: 1402 CPU-s, almost all from 27 separate integration-test binaries (~40–56 s each), each re-monomorphizing and optimizing axum/tokio/sqlite at opt-level 3.
• The same targets in dev profile: 125 CPU-s (~11× less).

Changes:

• kb-control-plane (19 files + common) and kb-cli (8 files) tests move to tests/it/ as modules of one binary per crate. There's no env/cwd mutation or fixed ports, so running them concurrently in one process is safe. common's blanket dead_code allow is gone because nothing is unused now.
• New [profile.ci-test] (dev, line-tables-only debug info, deps at opt-level 2). The test check builds with it from a new test-deps derivation, which, like workspace-deps, only rebuilds when Cargo.lock changes.
• All crane derivations link with mold (stdenvAdapters.useMoldLinker). This is Nix only: ares has no mold, so there's no .cargo/config.toml.

This is a one-off cache miss: mold changes the stdenv, so workspace-deps rebuilds once.

Verified locally: cargo clippy --workspace --all-targets -D warnings is clean, and nix build .#ci.build .#ci.clippy .#ci.test-deps passes. The full ci.test run is left to CI on this PR.

🤖 Generated with Claude Code

The Nix `test` check spent 30+ min compiling before any test ran (e.g. graph 582). Measured on ares (16 cores): - `cargo test --release --no-run` for the workspace crates: **1402 CPU-s**, almost all from 27 separate integration-test binaries (~40–56 s each), each re-monomorphizing and optimizing axum/tokio/sqlite at opt-level 3. - The same targets in dev profile: **125 CPU-s** (~11× less). Changes: - `kb-control-plane` (19 files + `common`) and `kb-cli` (8 files) tests move to `tests/it/` as modules of one binary per crate. There's no env/cwd mutation or fixed ports, so running them concurrently in one process is safe. `common`'s blanket `dead_code` allow is gone because nothing is unused now. - New `[profile.ci-test]` (dev, line-tables-only debug info, deps at opt-level 2). The `test` check builds with it from a new `test-deps` derivation, which, like `workspace-deps`, only rebuilds when Cargo.lock changes. - All crane derivations link with mold (`stdenvAdapters.useMoldLinker`). This is Nix only: ares has no mold, so there's no `.cargo/config.toml`. This is a one-off cache miss: mold changes the stdenv, so `workspace-deps` rebuilds once. Verified locally: `cargo clippy --workspace --all-targets -D warnings` is clean, and `nix build .#ci.build .#ci.clippy .#ci.test-deps` passes. The full `ci.test` run is left to CI on this PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

kris added 1 commit 2026-09-27 19:33:37 +02:00

CI: one integration-test binary per crate, ci-test profile, mold ... 4d3ba89116

The Nix test check spent 30+ minutes compiling before running a single
test: 27 separate integration-test binaries, each re-monomorphizing and
optimizing the axum/tokio/sqlite stack at opt-level 3 (~45s CPU apiece,
~1400 CPU-s total on a 16-core box).

- kb-control-plane and kb-cli tests move under tests/it/ as modules of
  a single binary each (19 + 8 binaries -> 2).
- The test check builds in a new `ci-test` profile (dev, deps at
  opt-level 2) from its own cached deps derivation; ~11x less compile
  CPU for the workspace crates than --release.
- All crane derivations link with mold.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

kris commented 2026-09-27 19:37:11 +02:00

Author

Owner

Copy link

@krisbuild r+

@krisbuild r+

kris commented 2026-09-27 19:43:57 +02:00

Author

Owner

Copy link

@krisbuild p=10

@krisbuild p=10

kris referenced this pull request 2026-09-27 19:44:29 +02:00

Node health: requeue infra failures, quarantine failing nodes, infra vs verdict statuses #8

krisbuild referenced this pull request from a commit 2026-09-27 19:44:31 +02:00

Auto merge of #18 - CI: one integration-test binary per crate, ci-test profile, mold, r=kris

kris added 2 commits 2026-09-27 19:45:46 +02:00

Merge remote-tracking branch 'origin/main' into faster-tests 51963fd32d

tests: fold agent_routes (from #11) into the control plane's single test binary ... 921636c2e5

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

krisbuild commented 2026-09-27 19:45:46 +02:00

Collaborator

Copy link

Removed from the merge queue: the pull-request head changed.

Removed from the merge queue: the pull-request head changed.

kris commented 2026-09-27 19:45:50 +02:00

Author

Owner

Copy link

Merged main (#11 landed after this branched) and moved #11's new tests/agent_routes.rs into tests/it/: left at the top level it became its own test target whose mod common; no longer resolves, so the merge candidate would not have compiled.

@krisbuild r+ p=10

Merged main (#11 landed after this branched) and moved #11's new `tests/agent_routes.rs` into `tests/it/`: left at the top level it became its own test target whose `mod common;` no longer resolves, so the merge candidate would not have compiled. @krisbuild r+ p=10

krisbuild referenced this pull request from a commit 2026-09-27 19:50:27 +02:00

Auto merge of #18 - CI: one integration-test binary per crate, ci-test profile, mold, r=kris

krisbuild manually merged commit 623eac009c into main 2026-09-27 19:50:30 +02:00

krisbuild commented 2026-09-27 19:50:30 +02:00

Collaborator

Copy link

Merged as 623eac009c.

Merged as 623eac009cb1.

kris referenced this pull request 2026-09-27 19:51:36 +02:00

tests: fix pr_events race between the eval result and the closed webhook #19

kris referenced this pull request 2026-09-27 19:54:14 +02:00

Re-evaluate when a cached eval's drvs are missing from the cache (SPEC §6.1) #17

kris referenced this pull request 2026-09-27 19:54:15 +02:00

Per-node attic push tokens issued by the control plane (SPEC §7.3.1) #13

kris referenced this pull request 2026-09-27 19:54:15 +02:00

Agent enrollment by approval (SPEC §7.1.1) #10

kris referenced this pull request from a commit 2026-09-27 19:54:50 +02:00

tests: node_health joins the single tests/it binary

kris referenced this pull request 2026-09-27 19:55:20 +02:00

Node health: requeue infra failures, quarantine failing nodes, infra vs verdict statuses #8

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

kris/krisbuild!18

No description provided.